Repository navigation
Speak to a crew left ashore after the last boat is sold - #285
Merged
Merged
Conversation
Margaret, Sam and Old Tom checked hasBoat before workers, so a player still paying a crew after selling their last hull was told they had no boat yet and no crew. Each now names the hands still on wages and points to a new hull or Dismiss a Worker. Margaret's no-crew line also names the actual hull instead of calling every tier a rowboat. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
"all 2 of your hands" read badly; use "your N hands are". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (head after the second commit, CI
Finding fixed during review:
Judgment notes (no change made):
This review comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hasBoatbeforeworkers, so this player was told "no boat yet" (Sam offered to find hands they already have, and Old Tom said they had no crew). Each_businessDialoguenow handles "no boat, crew still hired" first. It names the hands still on wages, with the right wording for one hand, and points to a new hull or Dismiss a Worker under Manage Fleet (offered there in this state,docks.py:431-435).A Trawler with no crew is just a hull and a dream!).src/location/bank.py,src/location/docks.py,src/location/tavern.pyand their tests. No persisted fields, schemas or protected paths are touched.Skipped open issues: #266 (the fix touches the protected
schemas/*.jsonand*JsonReaderWriterpaths), and #273, #276 and #280 (each needs a design decision from the owner, as recorded in their bodies).Test plan
addBoat→hireWorker×1/×2 →sellBoat) for all three NPCs, plus the hull name at tiers 1 and 2. The oldrowboat and a dreamassertion is replaced.src/changes stashed, all 8 new test cases fail. With the changes restored, they pass.blackwas run on the six changed files only.Closes #284
This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson